Auto-enable Vulkan in builds, and update docs for Vulkan backend#20525
Draft
Reubend wants to merge 2 commits into
Draft
Auto-enable Vulkan in builds, and update docs for Vulkan backend#20525Reubend wants to merge 2 commits into
Reubend wants to merge 2 commits into
Conversation
pytorch-bot
Bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20525
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 Unclassified FailuresAs of commit f951bdc with merge base bb28350 ( UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following up from #20138, this enables the Vulkan backend in source builds when its deps are present, mirroring what we do for CUDA, QNN, and OpenVINO.
It also updates the docs for the Vulkan backend to reflect the latest platform support.
fixes:#20140
Changes
is_vulkan_available(), based on the existingis_cuda_available()Testing
I tested these changes on a Linux machine with an A100. I'm relying on CI for Windows testing.
cc @SS-JIA @manuelcandales @digantdesai @cbilgin